ci: add luals workflow #3563
ci: add luals workflow #3563
Conversation
...pretty bad. |
clason
force-pushed
the
ci/luals
branch
2 times, most recently
from
5707890 to
cf19759
Compare
|
yeah, we dont have typing, luals wasnt that mature back then 😅 |
|
I guess all these luacats annotations we have are for something different then ;) |
|
|
||
| stylua: | ||
| name: stylua | ||
| name: Stylua |
There was a problem hiding this comment.
Note to self: This requires adapting the branch protection (required checks are case sensitive).
Since we're basically starting from scratch, we might as well switch to emmyluals already, which is quite a bit faster and has better support for generics. (It's also quite a bit stricter and still has some rough edges, and the Nvim runtime itself is not fully emmyluals compliant, which may be a problem.) |
annotations where used for doc generation, not type hints: https://github.com/tjdevries/tree-sitter-lua/blob/master/HOWTO.md but i think that one broke 2 years ago |
|
Yeah, I noticed on another PR (which is what started this whole rampage) ;) |
|
emmyluals has a docgen CLI; that could be another argument for switching, if we have to replace tools anyway. |
Optional for now; can be run locally with `make luacheck`.
Optional for now; can be run locally with
make luacheck. (I just want to see how bad this is going to be...)Also fix the lint workflow:
/luathese days)